[dpdk-dev] [PATCH] net/enic: retain previous message logging

[Ferruh Yigit]

On 7/25/2019 3:46 AM, John Daley wrote:
> Prior to fix, RTE_LOGTYPE_INFO messages would display in testpmd by
> default. After the fix, using dynamic logging, only NOTICE level and
> higher were displayed by default and INFO level were not. Change the
> messages to NOTICE level so they continue to display.
> 
> DTS uses testpmd and parses messages and some tests failed because
> messages were no longer displayed. Other apps may also depend on
> the messages.

If you need messages for the test framework, why not just increase the log level
for enic PMD via application parameter [1], or as command to testpmd[2]?
Since it is dynamic debug now, you don't need to change the default, can change
the level on demand.

[1]
starting testpmd with following option should do it:
--log-level=pmd.net.enic.*:info

testpmd --log-level=pmd.net.enic.*:info -- -i


[2]
after testpmd started, can change the debug level:
testpmd> set log pmd.net.enic 7


[3] bonus, see current log levels
testpmd> dump_log_types



> 
> Fixes: bbd8ecc05434 ("net/enic: remove PMD log type references")
> 
> Signed-off-by: John Daley <johndale at cisco.com>

<...>