[dpdk-dev] [PATCH v2] Revert "eal: fix parsing option --telemetry"

Thomas Monjalon thomas at monjalon.net
Mon Jul 29 22:06:27 CEST 2019


29/07/2019 10:40, David Marchand:
> On Sun, Jul 28, 2019 at 9:55 PM Thomas Monjalon <thomas at monjalon.net> wrote:
> > 25/07/2019 10:42, David Marchand:
> > > > > > 24/07/2019 17:20, Sean Morrissey:
> > > > On further investigation, the full fix involves
> > > > a change in the EAL command line parameter handling,
> > > > which is probably too risky for RC3.
> >
> > No way you change the command line parsing,
> > except the rte_option which was created for telemetry.
> > The history of this "simple" feature is already full
> > of hesitations which made me hesitate to merge.
> > Please, don't force me to dig in the code, otherwise
> > I will be tempted to do a big "clean-up".
> >
> > > > This revert will allow telemetry to function again,
> > > > but with the erroneous message still in place.
> > > > We will aim to fix in the next release.
> > >
> > > Might be good to look and revisit the rte_option api.
> 
> The patch on eal did not make any sense.
> I am for reverting it too.

OK, reverted.

Next time I will see a patch for telemetry, I will ask all questions
and will check by myself.




More information about the dev mailing list