[dpdk-dev] [PATCH v3 1/6] net/rte_ether: deinline non-critical functions

Andrew Rybchenko arybchenko at solarflare.com
Wed Jun 5 10:44:42 CEST 2019


On 6/5/19 4:08 AM, Stephen Hemminger wrote:
> Formatting ethernet address and getting a random value are
> not in critical path so they should not be inlined.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Rami Rosen <ramirose at gmail.com>

Meson build is lost plus one nit below.
Other than that:

Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>

[...]

> diff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map
> index 26c06e7c7ae7..dae6e420cded 100644
> --- a/lib/librte_net/rte_net_version.map
> +++ b/lib/librte_net/rte_net_version.map
> @@ -13,6 +13,13 @@ DPDK_17.05 {
>   
>   } DPDK_16.11;
>   
> +DPDK_19.08 {
> +	global:
> +
> +	eth_random_addr;
> +	eth_format_addr;

rte_ prefix is lost

> +} DPDK_17.05;
> +
>   EXPERIMENTAL {
>   	global:
>   



More information about the dev mailing list