[dpdk-dev] [PATCH 47/49] net/ice/base: enable additional switch rules

Maxime Coquelin maxime.coquelin at redhat.com
Fri Jun 7 14:41:24 CEST 2019



On 6/5/19 6:34 PM, Stillwell Jr, Paul M wrote:
>>>    	if (!s_rule)
>>> @@ -5576,8 +5606,8 @@ ice_add_adv_rule(struct ice_hw *hw, struct
>> ice_adv_lkup_elem *lkups,
>>>    	s_rule->pdata.lkup_tx_rx.recipe_id = CPU_TO_LE16(rid);
>>>    	s_rule->pdata.lkup_tx_rx.act = CPU_TO_LE32(act);
>>>
>>> -	ice_fill_adv_dummy_packet(lkups, lkups_cnt, rinfo->tun_type,
>> s_rule,
>>> -				  pkt, pkt_len);
>>> +	ice_fill_adv_dummy_packet(lkups, lkups_cnt, s_rule, pkt, pkt_len,
>>> +				  pkt_offsets);
>> Now that ice_fill_adv_dummy_packet() propagates an error, the caller
>> should do the same.
>>
> OK, can we accept this patch and have a separate patch that propagates the error? It will take some time to get a patch that propagates the error done.
> 

I'm OK with that, do you think it can be done for v19.08?


More information about the dev mailing list