[dpdk-dev] [PATCH v4 09/11] net/hinic: add RX module

Ferruh Yigit ferruh.yigit at intel.com
Tue Jun 11 17:57:31 CEST 2019


On 6/6/2019 12:06 PM, Ziyang Xuan wrote:
> Add code for RX module.
> 
> Signed-off-by: Ziyang Xuan <xuanziyang2 at huawei.com>
<...>

> @@ -0,0 +1,902 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2017 Huawei Technologies Co., Ltd
> + */
> +
> +#include <rte_ether.h>
> +#include <rte_ethdev.h>
> +#include <rte_mbuf.h>
> +#ifdef __ARM64_NEON__
> +#include <arm_neon.h>
> +#endif
> +
> +#include "hinic_pmd_ethdev.h"
> +#include "hinic_pmd_rx.h"
> +
> +#ifdef HINIC_XSTAT_RXBUF_INFO

Where this define is defined? I think it is not coming from Makefile.

<...>

> +#ifdef HINIC_XSTAT_RXBUF_INFO
> +	rxq->rxq_stats.rx_mbuf = (rxq->q_depth)
> +				- HINIC_GET_RQ_FREE_WQEBBS(rxq);
> +
> +	hinic_rxq_buffer_done_count(rxq);
> +#endif
> +#ifdef HINIC_XSTAT_MBUF_USE

Similar to this one, there are ifdefs in the code not defined, creating dead code.
Please don't have any compile time option that can't be modified from config file.


More information about the dev mailing list