[dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

Stephen Hemminger stephen at networkplumber.org
Tue Jun 11 22:54:16 CEST 2019


On Mon, 10 Jun 2019 10:51:48 -0700
Stephen Hemminger <stephen at networkplumber.org> wrote:

> While testing KNI with netvsc, saw lots of places more code
> could be safely removed from KNI kernel driver.
> 
> This is still mostly "putting lipstick on a pig" all users
> would be better off using virtio_user rather than KNI.
> 
> v2 - get rid of unnecessary padding, combine the unused field patches
> 
> Stephen Hemminger (7):
>   kni: don't need stubs for rx_mode or ioctl
>   kni: use netdev_alloc_skb
>   kni: don't keep stats in kni_net
>   kni: drop unused fields
>   kni: use proper type for kni fifo's
>   kni: return -EFAULT if copy_from_user fails
>   doc: update KNI documentation
> 
>  .../sample_app_ug/kernel_nic_interface.rst    | 18 ++---
>  kernel/linux/kni/kni_dev.h                    | 21 ++---
>  kernel/linux/kni/kni_misc.c                   | 17 ++--
>  kernel/linux/kni/kni_net.c                    | 79 +++++--------------
>  4 files changed, 38 insertions(+), 97 deletions(-)
> 

Don't believe patchwork the patch is fine, it is getting falsely blamed
for failures caused by other changes in ice, bnxt which fail
FreeBSD build.


More information about the dev mailing list