[dpdk-dev] [PATCH v2 0/7] kni: cleanups and improvements

[Lance Richardson]

On Tue, Jun 11, 2019 at 5:30 PM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> On Tue, 11 Jun 2019 17:18:42 -0400
> Lance Richardson <lance.richardson at broadcom.com> wrote:
>
> > On Tue, Jun 11, 2019 at 4:54 PM Stephen Hemminger
> > <stephen at networkplumber.org> wrote:
> > >
> > > On Mon, 10 Jun 2019 10:51:48 -0700
> > > Stephen Hemminger <stephen at networkplumber.org> wrote:
> > >
> > > > While testing KNI with netvsc, saw lots of places more code
> > > > could be safely removed from KNI kernel driver.
> > > >
> > > > This is still mostly "putting lipstick on a pig" all users
> > > > would be better off using virtio_user rather than KNI.
> > > >
> > > > v2 - get rid of unnecessary padding, combine the unused field patches
> > > >
> > > > Stephen Hemminger (7):
> > > >   kni: don't need stubs for rx_mode or ioctl
> > > >   kni: use netdev_alloc_skb
> > > >   kni: don't keep stats in kni_net
> > > >   kni: drop unused fields
> > > >   kni: use proper type for kni fifo's
> > > >   kni: return -EFAULT if copy_from_user fails
> > > >   doc: update KNI documentation
> > > >
> > > >  .../sample_app_ug/kernel_nic_interface.rst    | 18 ++---
> > > >  kernel/linux/kni/kni_dev.h                    | 21 ++---
> > > >  kernel/linux/kni/kni_misc.c                   | 17 ++--
> > > >  kernel/linux/kni/kni_net.c                    | 79 +++++--------------
> > > >  4 files changed, 38 insertions(+), 97 deletions(-)
> > > >
> > >
> > > Don't believe patchwork the patch is fine, it is getting falsely blamed
> > > for failures caused by other changes in ice, bnxt which fail
> > > FreeBSD build.
> >
> > Do you mean failures like the ones below? If so, I think think they
> > might be an unintended
> > consequence of commit a385972c3 "mk: disable warning for packed member pointer".
> >
> >     Lance
> >
> > OS: FreeBSD12-64
> > Target: x86_64-native-bsdapp-gcc
> >   CC ice_rxtx.o
> >   CC ice_ethdev.o
> > cc1: error: unrecognized command line option
> > '-Wno-address-of-packed-member' [-Werror]
> > cc1: all warnings being treated as errors
> > gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/internal/rte.compile-pre.mk:114:
> > bnxt_ethdev.o] Error 1
> > gmake[5]: *** [/tmp/FreeBSD12-64_K19.02_GCC7.3.0/x86_64-native-bsdapp-gcc/e6c3bc062b1045128114bdf0cfdd236b/dpdk/mk/rte.subdir.mk:37:
> > bnxt] Error 2
> > gmake[5]: *** Waiting for unfinished jobs....
>
>
> More than just that

OK, I see now... I'll spin a fix for this one:

> OS: FreeBSD12-64
> Target: x86_64-native-bsdapp-clang
> #define roundup(x, y)   ((((x)+((y)-1))/(y))*(y))  /* to any y */
>         ^
> 1 error generated.
> gmake[6]: *** [/tmp/FreeBSD12-64_K19.02_Clang6.0.1/x86_64-native-bsdapp-clang/025b54b548ed4ca894cbf5e754039b68/dpdk/mk/internal/rte.compile-pre.mk:114: bnxt_ethdev.o] Error 1

Thanks,

   Lance