[dpdk-dev] [PATCH 15/39] eventdev: add routines for logging eventmode helper

Anoob Joseph anoobj at marvell.com
Mon Jun 17 11:09:29 CEST 2019


Hi Jerin,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 10, 2019 3:43 PM
> To: Anoob Joseph <anoobj at marvell.com>; Nikhil Rao
> <nikhil.rao at intel.com>; Erik Gabriel Carrillo <erik.g.carrillo at intel.com>;
> Abhinandan Gujjar <abhinandan.gujjar at intel.com>; Bruce Richardson
> <bruce.richardson at intel.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>
> Cc: Anoob Joseph <anoobj at marvell.com>; Narayana Prasad Raju Athreya
> <pathreya at marvell.com>; dev at dpdk.org; Lukas Bartosik
> <lbartosik at marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>; Nipun Gupta <nipun.gupta at nxp.com>; Harry
> van Haaren <harry.van.haaren at intel.com>; Mattias Rönnblom
> <mattias.ronnblom at ericsson.com>; Liang Ma <liang.j.ma at intel.com>
> Subject: RE: [PATCH 15/39] eventdev: add routines for logging eventmode
> helper
> 
> > -----Original Message-----
> > From: Anoob Joseph <anoobj at marvell.com>
> > Sent: Monday, June 3, 2019 11:02 PM
> > To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Nikhil Rao
> > <nikhil.rao at intel.com>; Erik Gabriel Carrillo
> > <erik.g.carrillo at intel.com>; Abhinandan Gujjar
> > <abhinandan.gujjar at intel.com>; Bruce Richardson
> > <bruce.richardson at intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch at intel.com>
> > Cc: Anoob Joseph <anoobj at marvell.com>; Narayana Prasad Raju Athreya
> > <pathreya at marvell.com>; dev at dpdk.org; Lukas Bartosik
> > <lbartosik at marvell.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula at marvell.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>;
> > Nipun Gupta <nipun.gupta at nxp.com>; Harry van Haaren
> > <harry.van.haaren at intel.com>; Mattias Rönnblom
> > <mattias.ronnblom at ericsson.com>; Liang Ma <liang.j.ma at intel.com>
> > Subject: [PATCH 15/39] eventdev: add routines for logging eventmode
> > helper
> >
> > Adding routines for logging eventmode helper.
> >
> > Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> > Signed-off-by: Lukasz Bartosik <lbartosik at marvell.com>
> > ---
> >  config/common_base                                 |  1 +
> >  lib/librte_eal/common/eal_common_log.c             |  1 +
> >  lib/librte_eal/common/include/rte_log.h            |  1 +
> >  .../rte_eventmode_helper_internal.h                | 29
> > ++++++++++++++++++++++
> >  4 files changed, 32 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > 8576973..96c2537 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -685,6 +685,7 @@ CONFIG_RTE_LIBRTE_PMD_ZLIB=n  #
> > CONFIG_RTE_LIBRTE_EVENTDEV=y
> CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG=n
> > +CONFIG_RTE_LIBRTE_EVENTMODE_HELPER_DEBUG=n
> >  CONFIG_RTE_EVENT_MAX_DEVS=16
> >  CONFIG_RTE_EVENT_MAX_QUEUES_PER_DEV=64
> >  CONFIG_RTE_EVENT_TIMER_ADAPTER_NUM_MAX=32
> > diff --git a/lib/librte_eal/common/eal_common_log.c
> > b/lib/librte_eal/common/eal_common_log.c
> > index c714a4b..bc34dc2 100644
> > --- a/lib/librte_eal/common/eal_common_log.c
> > +++ b/lib/librte_eal/common/eal_common_log.c
> > @@ -324,6 +324,7 @@ static const struct logtype logtype_strings[] = {
> >  	{RTE_LOGTYPE_EFD,        "lib.efd"},
> >  	{RTE_LOGTYPE_EVENTDEV,   "lib.eventdev"},
> >  	{RTE_LOGTYPE_GSO,        "lib.gso"},
> > +	{RTE_LOGTYPE_EVENTMODE,  "lib.eventmode"},
> 
> EAL log type, typically adds for subsystem. Please reuse EVENTDEV_DEBUG
> Or introduce dynamic debugging.

[Anoob] Will make this change in v2. In that case, this patch can be dropped.


More information about the dev mailing list