[dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework

Anoob Joseph anoobj at marvell.com
Mon Jun 17 12:14:38 CEST 2019


Hi Jerin,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 10, 2019 3:49 PM
> To: Anoob Joseph <anoobj at marvell.com>; Nikhil Rao
> <nikhil.rao at intel.com>; Erik Gabriel Carrillo <erik.g.carrillo at intel.com>;
> Abhinandan Gujjar <abhinandan.gujjar at intel.com>; Bruce Richardson
> <bruce.richardson at intel.com>; Pablo de Lara
> <pablo.de.lara.guarch at intel.com>
> Cc: Anoob Joseph <anoobj at marvell.com>; Narayana Prasad Raju Athreya
> <pathreya at marvell.com>; dev at dpdk.org; Lukas Bartosik
> <lbartosik at marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavatula at marvell.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>; Nipun Gupta <nipun.gupta at nxp.com>; Harry
> van Haaren <harry.van.haaren at intel.com>; Mattias Rönnblom
> <mattias.ronnblom at ericsson.com>; Liang Ma <liang.j.ma at intel.com>
> Subject: RE: [PATCH 16/39] eventdev: add eventmode CL options framework
> 
> > -----Original Message-----
> > From: Anoob Joseph <anoobj at marvell.com>
> > Sent: Monday, June 3, 2019 11:02 PM
> > To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Nikhil Rao
> > <nikhil.rao at intel.com>; Erik Gabriel Carrillo
> > <erik.g.carrillo at intel.com>; Abhinandan Gujjar
> > <abhinandan.gujjar at intel.com>; Bruce Richardson
> > <bruce.richardson at intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch at intel.com>
> > Cc: Anoob Joseph <anoobj at marvell.com>; Narayana Prasad Raju Athreya
> > <pathreya at marvell.com>; dev at dpdk.org; Lukas Bartosik
> > <lbartosik at marvell.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula at marvell.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>;
> > Nipun Gupta <nipun.gupta at nxp.com>; Harry van Haaren
> > <harry.van.haaren at intel.com>; Mattias Rönnblom
> > <mattias.ronnblom at ericsson.com>; Liang Ma <liang.j.ma at intel.com>
> > Subject: [PATCH 16/39] eventdev: add eventmode CL options framework
> >
> > Adding usage prints and CL parsing routines for eventmode. Option to
> > select packet transfer mode is also added.
> >
> > Signed-off-by: Anoob Joseph <anoobj at marvell.com>
> > Signed-off-by: Lukasz Bartosik <lbartosik at marvell.com>
> > ---
> > +#include <rte_compat.h>
> > +
> > +/* Packet transfer mode of the application */ enum
> > +rte_eventmode_helper_pkt_transfer_mode {
> > +	RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL = 0,
> > +	RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT,
> > +};
> 
> Need to mark all public structues as EXPERIMENTAL.
> Please grep for EXPERIMENTAL in libeventdev or any other library

[Anoob] Will fix in v2.

> 
> > +struct rte_eventmode_helper_conf {
> > +	enum rte_eventmode_helper_pkt_transfer_mode mode;
> > +		/**< Packet transfer mode of the application */
> > +	void *mode_params;
> > +		/**< Mode specific parameters */
> > +};
> 
> Please make this event_helper object as 'opaque'  and move to internal so
> that it does have ABI policies and future new features can be added.
> 

[Anoob] The member, "mode_params" is the opaque pointer which is used internally. There are two fields which need to be communicated between application and helper library.

1. mode: whether the application is running in event-mode or poll-mode. Both application and helper library would need this. This field is set by the helper while parsing the eventmode args.
2. eth_portmask: helper library needs this info from application to know which all ethernet ports it can use. This is determined by the application and has to be communicated to the helper library. This can be made as params passed to the application, but eth_portmask will be the only member in it, as of now.

With the above use case, do you recommend any different structure layout?



More information about the dev mailing list