[dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver

[Li, Xiaoyun]

Yes. Thanks for catching that.

> -----Original Message-----
> From: Wang, Xiao W
> Sent: Monday, June 17, 2019 20:49
> To: Li, Xiaoyun <xiaoyun.li at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>;
> Wiles, Keith <keith.wiles at intel.com>; Liang, Cunming
> <cunming.liang at intel.com>; Maslekar, Omkar <omkar.maslekar at intel.com>
> Cc: dev at dpdk.org; Li, Xiaoyun <xiaoyun.li at intel.com>
> Subject: RE: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver
> 
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xiaoyun Li
> > Sent: Friday, June 14, 2019 10:20 AM
> > To: Wu, Jingjing <jingjing.wu at intel.com>; Wiles, Keith
> > <keith.wiles at intel.com>; Liang, Cunming <cunming.liang at intel.com>;
> > Maslekar, Omkar <omkar.maslekar at intel.com>
> > Cc: dev at dpdk.org; Li, Xiaoyun <xiaoyun.li at intel.com>
> > Subject: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev
> > driver
> >
> > Introduce rawdev driver support for NTB (Non-transparent Bridge) which
> > can help to connect two separate hosts with each other.
> >
> > Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> > ---
> >  config/common_base                            |   5 +
> >  drivers/raw/Makefile                          |   1 +
> >  drivers/raw/meson.build                       |   2 +-
> >  drivers/raw/ntb_rawdev/Makefile               |  27 +
> >  drivers/raw/ntb_rawdev/meson.build            |   7 +
> >  drivers/raw/ntb_rawdev/ntb_rawdev.c           | 500 ++++++++++++++++++
> >  drivers/raw/ntb_rawdev/ntb_rawdev.h           | 158 ++++++
> >  .../ntb_rawdev/rte_pmd_ntb_rawdev_version.map |   4 +
> >  mk/rte.app.mk                                 |   1 +
> >  9 files changed, 704 insertions(+), 1 deletion(-)  create mode 100644
> > drivers/raw/ntb_rawdev/Makefile  create mode 100644
> > drivers/raw/ntb_rawdev/meson.build
> >  create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.c
> >  create mode 100644 drivers/raw/ntb_rawdev/ntb_rawdev.h
> >  create mode 100644
> > drivers/raw/ntb_rawdev/rte_pmd_ntb_rawdev_version.map
> >
> > diff --git a/config/common_base b/config/common_base index
> > e406e7836..45e403130 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -746,6 +746,11 @@
> > CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n
> >  #
> >  CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=y
> >
> > +#
> > +# Compile PMD for NTB raw device
> > +#
> > +CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV=y
> > +
> >  #
> >  # Compile librte_ring
> >  #
> > diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile index
> > 8e29b4a56..efe61f451 100644
> > --- a/drivers/raw/Makefile
> > +++ b/drivers/raw/Makefile
> > @@ -10,5 +10,6 @@ DIRS-
> > $(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) += dpaa2_cmdif
> >  DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV) += dpaa2_qdma
> endif
> >  DIRS-$(CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV) += ifpga_rawdev
> > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV) += ntb_rawdev
> >
> >  include $(RTE_SDK)/mk/rte.subdir.mk
> > diff --git a/drivers/raw/meson.build b/drivers/raw/meson.build index
> > a61cdccef..6abf659d0 100644
> > --- a/drivers/raw/meson.build
> > +++ b/drivers/raw/meson.build
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: BSD-3-Clause  # Copyright 2018 NXP
> >
> > -drivers = ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma',
> > 'ifpga_rawdev']
> > +drivers = ['skeleton_rawdev', 'dpaa2_cmdif', 'dpaa2_qdma',
> > +'ifpga_rawdev',
> > 'ntb_rawdev']
> >  std_deps = ['rawdev']
> >  config_flag_fmt = 'RTE_LIBRTE_PMD_ at 0@_RAWDEV'
> >  driver_name_fmt = 'rte_pmd_ at 0@'
> > diff --git a/drivers/raw/ntb_rawdev/Makefile
> > b/drivers/raw/ntb_rawdev/Makefile new file mode 100644 index
> > 000000000..fb40204c1
> > --- /dev/null
> > +++ b/drivers/raw/ntb_rawdev/Makefile
> > @@ -0,0 +1,27 @@
> > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel
> > +Corporation
> > +
> > +include $(RTE_SDK)/mk/rte.vars.mk
> > +
> > +#
> > +# library name
> > +#
> > +LIB = librte_pmd_ntb_rawdev.a
> > +
> > +CFLAGS += -DALLOW_EXPERIMENTAL_API
> > +CFLAGS += -O3
> > +CFLAGS += $(WERROR_FLAGS)
> > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool LDLIBS += -lrte_pci
> > +-lrte_bus_pci LDLIBS += -lrte_rawdev
> > +
> > +EXPORT_MAP := rte_pmd_ntb_rawdev_version.map
> > +
> > +LIBABIVER := 1
> > +
> > +#
> > +# all source are stored in SRCS-y
> > +#
> > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += ntb_rawdev.c
> 
> Is it a typo? I think it should be CONFIG_RTE_LIBRTE_PMD_NTB_RAWDEV
> 
> BRs,
> Xiao
> 
> > +
> > +include $(RTE_SDK)/mk/rte.lib.mk
> > diff --git a/drivers/raw/ntb_rawdev/meson.build
> > b/drivers/raw/ntb_rawdev/meson.build
> > new file mode 100644
> > index 000000000..ca905049d
> [...]