[dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

Tiwei Bie tiwei.bie at intel.com
Tue Jun 18 06:42:28 CEST 2019


On Mon, Jun 17, 2019 at 12:31:38PM +0100, Andrew Rybchenko wrote:
> From: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
> 
> VLAN tag insertion should be in Tx prepare, not in Tx burst functions.
> One of Tx prepare goals is to be able to do preparations in advance
> (possibliy on different CPU core) and then transmit it fast.
> Also Tx prepare can report that a packet does not pass Tx offloads
> check. E.g. has no enough headroom to insert VLAN header.
> 
> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> ---
> v4:
>  - add more details to commit log
> 
>  drivers/net/virtio/virtio_rxtx.c | 50 +++++++++-----------------------
>  1 file changed, 14 insertions(+), 36 deletions(-)

Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>

Thanks,
Tiwei


More information about the dev mailing list