[dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

[David Marchand]

On Tue, Jun 18, 2019 at 12:59 PM Andrius Sirvys <andrius.sirvys at intel.com>
wrote:

> crc_strip was removed from lib/librte_ethdev/rte_ethdev.c as the
> NICs carry out this operation themselves. However once removed,
> the references to it we're forgotten to be taken out in test-pmd.
>
> Fixes: 323e7b667f18 ("ethdev: make default behavior CRC strip on Rx")
> Cc: ferruh.yigit at intel.com
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys at intel.com>
> ---
>  app/test-pmd/cmdline.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index d1e0d4402..cd3f33add 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -878,7 +878,7 @@ static void cmd_help_long_parsed(void *parsed_result,
>                         "port config <port_id> rx_offload vlan_strip|"
>
> "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
>                         "outer_ipv4_cksum|macsec_strip|header_split|"
> -                       "vlan_filter|vlan_extend|jumbo_frame|crc_strip|"
> +                       "vlan_filter|vlan_extend|jumbo_frame|"
>                         "scatter|timestamp|security|keep_crc on|off\n"
>                         "     Enable or disable a per port Rx offloading"
>                         " on all Rx queues of a port\n\n"
> @@ -886,7 +886,7 @@ static void cmd_help_long_parsed(void *parsed_result,
>                         "port (port_id) rxq (queue_id) rx_offload
> vlan_strip|"
>
> "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
>                         "outer_ipv4_cksum|macsec_strip|header_split|"
> -                       "vlan_filter|vlan_extend|jumbo_frame|crc_strip|"
> +                       "vlan_filter|vlan_extend|jumbo_frame|"
>                         "scatter|timestamp|security|keep_crc on|off\n"
>                         "    Enable or disable a per queue Rx offloading"
>                         " only on a specific Rx queue\n\n"
> @@ -17991,7 +17991,7 @@ cmdline_parse_token_string_t
> cmd_config_per_port_rx_offload_result_offload =
>                  offload,
> "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
>                            "qinq_strip#outer_ipv4_cksum#macsec_strip#"
>
>  "header_split#vlan_filter#vlan_extend#jumbo_frame#"
> -
> "crc_strip#scatter#timestamp#security#keep_crc");
> +                          "scatter#timestamp#security#keep_crc");
>  cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off
> =
>         TOKEN_STRING_INITIALIZER
>                 (struct cmd_config_per_port_rx_offload_result,
> @@ -18067,7 +18067,7 @@ cmdline_parse_inst_t
> cmd_config_per_port_rx_offload = {
>         .help_str = "port config <port_id> rx_offload
> vlan_strip|ipv4_cksum|"
>
> "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
>                     "macsec_strip|header_split|vlan_filter|vlan_extend|"
> -
>  "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
> +                   "jumbo_frame|scatter|timestamp|security|keep_crc "
>                     "on|off",
>         .tokens = {
>                 (void *)&cmd_config_per_port_rx_offload_result_port,
> @@ -18117,7 +18117,7 @@ cmdline_parse_token_string_t
> cmd_config_per_queue_rx_offload_result_offload =
>                  offload,
> "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
>                            "qinq_strip#outer_ipv4_cksum#macsec_strip#"
>
>  "header_split#vlan_filter#vlan_extend#jumbo_frame#"
> -
> "crc_strip#scatter#timestamp#security#keep_crc");
> +                          "scatter#timestamp#security#keep_crc");
>  cmdline_parse_token_string_t
> cmd_config_per_queue_rx_offload_result_on_off =
>         TOKEN_STRING_INITIALIZER
>                 (struct cmd_config_per_queue_rx_offload_result,
> @@ -18169,7 +18169,7 @@ cmdline_parse_inst_t
> cmd_config_per_queue_rx_offload = {
>                     "vlan_strip|ipv4_cksum|"
>
> "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
>                     "macsec_strip|header_split|vlan_filter|vlan_extend|"
> -
>  "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
> +                   "jumbo_frame|scatter|timestamp|security|keep_crc "
>                     "on|off",
>         .tokens = {
>                 (void *)&cmd_config_per_queue_rx_offload_result_port,
> --
> 2.17.1
>

Rather than fix this list in all those places, is it possible to use
rte_rx_offload_names[] in a little wrapper in testpmd?
The same would have to be done with the tx flags after this.


-- 
David Marchand