[dpdk-dev] [PATCH 1/2] net/vhost: support TSO disabling

[Matan Azrad]

Hi Tiwei, Maxim
From: Tiwei Bie 
> Sent: Thursday, June 20, 2019 5:26 AM
> To: Maxime Coquelin <maxime.coquelin at redhat.com>
> Cc: Noa Ezra <noae at mellanox.com>; Matan Azrad <matan at mellanox.com>;
> dev at dpdk.org
> Subject: Re: [PATCH 1/2] net/vhost: support TSO disabling
> 
> On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wrote:
> > On 6/19/19 8:13 AM, Noa Ezra wrote:
> > > TSO (TCP Segmentation Offload) is enabled by default on vhost.
> > > Add the ability to disable TSO on vhost.
> > > The user should also disable the feature on the virtual machine's xml.
> >
> > For TSO, I think it make sense to have the option to disable it, as it
> > requires the application to support it.
> >
> > I even wonder whether it should not be disabled by default.
> > Any thoughts?
> 
> Agree, it looks better to disable it by default.

The issue to disable it by default is that it will break the current applications/users which use TSO by default.

Maybe we need kind of notice to the user to break it in the next version.

What do you think?  
 
> Thanks,
> Tiwei