[dpdk-dev] [PATCH 00/29] net/sfc/base: update base driver
arybchenko at solarflare.com
Mon Jun 24 09:53:35 CEST 2019
On 6/24/19 1:37 AM, Thomas Monjalon wrote:
> 18/06/2019 09:52, Ferruh Yigit:
>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote:
>>> checkpatches.sh generates warnings/errors because of a bit different
>>> coding style in base driver.
>> Series applied to dpdk-next-net/master, thanks.
>> Fixed following checkpatch warnings while merging:
> There are a lot more checkpatch warnings in this code.
> Is it possible to fix the style of the code in the sfc/base directory?
> Or we prefer to continue with so many checkpatch warnings?
In short: I'm trying to minimize a number of warnings, but it is not always
possible. I'll pay even more attention to it in the future.
The base driver is used for other OS drivers and coding style in the base
driver is a common denominator of their coding styles plus some kind
of established practices. Unfortunately some points in coding style in
FreeBSD and GLD (Solaris) contradict to DPDK coding style.
Of course, there is a grey area and we're trying to avoid checkpatches.sh
warning there. Sometimes even changing existing practices, but anyway
major changes of coding style in existing sources is not a good idea.
More information about the dev