[dpdk-dev] [PATCH 2/2] net/qede: fix warnings from invalid assert

Morten Brørup mb at smartsharesystems.com
Mon Jun 24 11:23:23 CEST 2019


> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
> 
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
> 
> Fixes: 2af14ca79c0a ("net/qede: support 100G")
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  drivers/net/qede/qede_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/qede/qede_ethdev.c
> b/drivers/net/qede/qede_ethdev.c
> index 84d898421bd4..82363e6eba93 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -1426,7 +1426,6 @@ static void qede_poll_sp_sb_cb(void *param)
>  	if (rc != 0) {
>  		DP_ERR(edev, "Unable to start periodic"
>  			     " timer rc %d\n", rc);
> -		assert(false && "Unable to start periodic timer");
>  	}
>  }
> 
> --
> 2.20.1
> 

Acked-by: Morten Brørup <mb at smartsharesystems.com>



More information about the dev mailing list