[dpdk-dev] [PATCH v5 10/15] net/hinic: add various headers

Ferruh Yigit ferruh.yigit at intel.com
Wed Jun 26 13:54:24 CEST 2019


On 6/19/2019 5:08 PM, Ziyang Xuan wrote:
> Add various headers that define mgmt commands, cmdq commands,
> rx data structures, tx data structures, private adapter data
> structures and basic defines for use in the code.
> 
> Signed-off-by: Ziyang Xuan <xuanziyang2 at huawei.com>
> ---
>  drivers/net/hinic/base/hinic_compat.h  | 256 ++++++++++++++
>  drivers/net/hinic/base/hinic_pmd_cmd.h | 453 +++++++++++++++++++++++++
>  drivers/net/hinic/hinic_pmd_ethdev.h   |  71 ++++
>  drivers/net/hinic/hinic_pmd_rx.h       | 128 +++++++
>  drivers/net/hinic/hinic_pmd_tx.h       | 143 ++++++++
>  5 files changed, 1051 insertions(+)
>  create mode 100644 drivers/net/hinic/base/hinic_compat.h
>  create mode 100644 drivers/net/hinic/base/hinic_pmd_cmd.h
>  create mode 100644 drivers/net/hinic/hinic_pmd_ethdev.h
>  create mode 100644 drivers/net/hinic/hinic_pmd_rx.h
>  create mode 100644 drivers/net/hinic/hinic_pmd_tx.h

OK for base file headers, but not if adding PMD header files in advance with a
commit is a good idea.

Can you please add those headers when they are used, it looks like

"hinic_pmd_ethdev.h" can be added on patch 11/15
"hinic_pmd_rx.h"/"hinic_pmd_tx.h" can be added on patch 12/15


More information about the dev mailing list