[dpdk-dev] [PATCH 3/4] eal: allow checking CPU flags by name

David Marchand david.marchand at redhat.com
Thu Jun 27 15:22:14 CEST 2019


On Wed, May 29, 2019 at 5:42 PM Bruce Richardson <bruce.richardson at intel.com>
wrote:

> Rather than using enum values for CPU flags, which means the symbols don't
> exist on other architectures, provide a flag lookup by name, allowing us to
> unconditionally check for a CPU flag.
>

Did you consider passing a string for the CPU architecture rather than an
enum?
It would have to be compared to RTE_ARCH in rte_cpu_get_flagname_enabled.
Or to accomodate with x86_64/i686, this could be a cpu arch family.

This avoids adding a new C type that seems quite limited wrt its uses.

-- 
David Marchand


More information about the dev mailing list