[dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

Stephen Hemminger stephen at networkplumber.org
Thu Jun 27 17:24:51 CEST 2019


On Thu, 27 Jun 2019 17:37:49 +0800
Ruifeng Wang <ruifeng.wang at arm.com> wrote:

> Tests showed that the function inlining caused performance drop
> on some x86 platforms with the memory ordering patches applied.
> By force no-inline functions, the performance was better than
> before on x86 and no impact to arm64 platforms.
> 
> Suggested-by: Medvedkin Vladimir <vladimir.medvedkin at intel.com>
> Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
> Reviewed-by: Gavin Hu <gavin.hu at arm.com>
 {

Do you actually need to force noinline or is just taking of inline enough?
In general, letting compiler decide is often best practice.


More information about the dev mailing list