[dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build infra and device probe

Pavan Nikhilesh Bhagavatula pbhagavatula at marvell.com
Fri Jun 28 11:01:15 CEST 2019


Hi Thomas,

Will correct the flag order in v3.

Thanks,
Pavan.

>-----Original Message-----
>From: Thomas Monjalon <thomas at monjalon.net>
>Sent: Friday, June 28, 2019 2:25 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com>
>Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Anatoly Burakov
><anatoly.burakov at intel.com>; dev at dpdk.org; Nithin Kumar
>Dabilpuram <ndabilpuram at marvell.com>
>Subject: Re: [dpdk-dev] [PATCH v2 01/44] event/octeontx2: add build
>infra and device probe
>
>Hi,
>I'm checking some ordering in this patch:
>
>28/06/2019 09:49, pbhagavatula at marvell.com:
>> From: Pavan Nikhilesh <pbhagavatula at marvell.com>
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -747,6 +747,11 @@
>CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n
>>  #
>>  CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=y
>>
>> +#
>> +# Compile PMD for octeontx sso event device
>> +#
>> +CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV=y
>
>Looks like you chose this line randomly?
>
>Would be better to add after
>CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF.
>
>>  #
>>  # Compile librte_ring
>>  #
>> diff --git a/drivers/event/Makefile b/drivers/event/Makefile
>> index 03ad1b6cb..e4e7eff37 100644
>> --- a/drivers/event/Makefile
>> +++ b/drivers/event/Makefile
>> @@ -15,5 +15,6 @@ ifeq
>($(CONFIG_RTE_EAL_VFIO)$(CONFIG_RTE_LIBRTE_FSLMC_BUS),yy)
>>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV) += dpaa2
>>  endif
>>  DIRS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += opdl
>> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) +=
>octeontx2
>
>Same here, should be after octeontx.
>
>> --- a/drivers/event/meson.build
>> +++ b/drivers/event/meson.build
>> @@ -1,7 +1,7 @@
>>  # SPDX-License-Identifier: BSD-3-Clause
>>  # Copyright(c) 2017 Intel Corporation
>>
>> -drivers = ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw']
>> +drivers = ['dpaa', 'dpaa2', 'opdl', 'skeleton', 'sw', 'dsw', 'octeontx2']
>
>Could be before opdl (and keep SW ones at the end).
>
>> --- a/mk/rte.app.mk
>> +++ b/mk/rte.app.mk
>> @@ -109,6 +109,7 @@ ifeq
>($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBR
>TE_OCTEONTX_MEMPOO
>>  _LDLIBS-y += -lrte_common_octeontx
>>  endif
>>  OCTEONTX2-y := $(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL)
>> +OCTEONTX2-y +=
>$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV)
>>  ifeq ($(findstring y,$(OCTEONTX2-y)),y)
>>  _LDLIBS-y += -lrte_common_octeontx2
>>  endif
>> @@ -293,6 +294,7 @@ endif # CONFIG_RTE_LIBRTE_FSLMC_BUS
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL) += -
>lrte_mempool_octeontx
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX_PMD) += -
>lrte_pmd_octeontx
>>  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OPDL_EVENTDEV) += -
>lrte_pmd_opdl_event
>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_OCTEONTX2_EVENTDEV) += -
>lrte_pmd_octeontx2_event
>
>Should be after OCTEONTX.
>
>>  endif # CONFIG_RTE_LIBRTE_EVENTDEV
>
>



More information about the dev mailing list