[dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

Ferruh Yigit ferruh.yigit at intel.com
Fri Jun 28 18:24:22 CEST 2019


On 6/28/2019 11:47 AM, Ananyev, Konstantin wrote:
> 
> 
>> -----Original Message-----
>> From: Ivan Malov [mailto:ivan.malov at oktetlabs.ru]
>> Sent: Friday, June 28, 2019 4:13 AM
>> To: Olivier Matz <olivier.matz at 6wind.com>
>> Cc: dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com>; Andrew Rybchenko <arybchenko at solarflare.com>; Stephen
>> Hemminger <stephen at networkplumber.org>; Kulasek, TomaszX <tomaszx.kulasek at intel.com>; stable at dpdk.org
>> Subject: [PATCH v3] net: fix the way how L4 checksum choice is tested
>>
>> The API to prepare checksum offloads mistreats L4
>> checksum type enum values as self-contained flags.
>>
>> Turning these flag checks into enum checks causes
>> warnings by GCC about possibly uninitialised IPv4
>> header pointer. The issue was found to show up in
>> the case of GCC versions 4.8.5 and 5.4.0, however,
>> it might be the case for a wider variety of other
>> versions. Initialise the pointer upon declaration.
>> and explain the reason behind this in the comment.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Cc: Tomasz Kulasek <tomaszx.kulasek at intel.com>
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Ivan Malov <ivan.malov at oktetlabs.ru>
>> Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> 

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list