[dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

David Harton dharton at cisco.com
Fri Mar 8 21:34:30 CET 2019


ixgbevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.

Restoring the capbility to enable these offloads at
configuration time.

Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton <dharton at cisco.com>
---

v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e92a70fb3..b1b83613e 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2813,23 +2813,6 @@ ixgbe_reset_rx_queue(struct ixgbe_adapter *adapter, struct ixgbe_rx_queue *rxq)
 #endif
 }
 
-static int
-ixgbe_is_vf(struct rte_eth_dev *dev)
-{
-	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
-
-	switch (hw->mac.type) {
-	case ixgbe_mac_82599_vf:
-	case ixgbe_mac_X540_vf:
-	case ixgbe_mac_X550_vf:
-	case ixgbe_mac_X550EM_x_vf:
-	case ixgbe_mac_X550EM_a_vf:
-		return 1;
-	default:
-		return 0;
-	}
-}
-
 uint64_t
 ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev)
 {
@@ -2853,15 +2836,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
+		   DEV_RX_OFFLOAD_VLAN_EXTEND |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
-	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
-
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
 	 * mode.
-- 
2.19.1



More information about the dev mailing list