[dpdk-dev] [PATCH v2] ring: enforce reading the tails before ring operations
Thomas Monjalon
thomas at monjalon.net
Sat Mar 9 00:18:08 CET 2019
08/03/2019 16:50, Ananyev, Konstantin:
> 08/03/2019 16:05, Gavin Hu (Arm Technology China):
> > Anyway, on x86, smp_rmb, as a compiler barrier, applies to load/store, not only load/load.
>
> Yes, that's true, but I think that's happened by coincidence,
> not intentionally.
>
> > This is the case also for arm, arm64, ppc32, ppc64.
> > I will submit a patch to expand the definition of this API.
>
> I understand your intention, but that does mean we would also need
> to change not only rte_smp_rmb() but rte_rmb() too (to keep things consistent)?
> That sounds worring.
> Might be better to keep smp_rmb() definition as it is, and introduce new function
> that fits your purposes (smp_rwmb or smp_load_store_barrier)?
How is it managed in other projects?
More information about the dev
mailing list