[dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding

[Kevin Traynor]

On 11/03/2019 12:35, Ferruh Yigit wrote:
> On 3/11/2019 2:18 AM, Zhang, Qi Z wrote:
>>
>>
>>> -----Original Message-----
>>> From: Kevin Traynor [mailto:ktraynor at redhat.com]
>>> Sent: Wednesday, March 6, 2019 12:31 AM
>>> To: Zhang, Qi Z <qi.z.zhang at intel.com>
>>> Cc: dev at dpdk.org; Kevin Traynor <ktraynor at redhat.com>; Yan, Zhirun
>>> <zhirun.yan at intel.com>
>>> Subject: [RFC 2/2] net/i40e: update requested queue pair num check for
>>> rounding
>>>
>>> Since rounding up the requested queue pairs to allow the vf to request a
>>> non-aligned number was added, it may happen that the requested number is
>>> less than the available num of queues but the rounded up number is greater. In
>>> this case, it is not caught with the usual checks but later when there is a reset and
>>> failed setup.
>>>
>>> By rounding earlier the checks can be done before a failed reset occurs, and a
>>> rounded max amount of available queues can be returned to the vf.
>>>
>>> Cc: zhirun.yan at intel.com
>>> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
>>
>> Acked-by: Qi Zhang <qi.z.zhang at intel.com>
>>
>> Applied to dpdk-next-net-intel.
>>
> 
> These were checkpatch warnings because of whitespace (spaces before tabs), fixed
> while merging to next-net.
> 

Thanks Ferruh. Not spaces before tabs, but using spaces for alignment
where there was room for an additional tab. I misinterpreted "spaces for
alignment" in the CS note. Maybe it's clear for others, but I'll send a
small clarification so I'll remember next time :-)