[dpdk-dev] [PATCH v2 1/4] build: add single source of DPDK version number

[Thomas Monjalon]

07/03/2019 14:34, Bruce Richardson:
> Add a new file DPDK_VERSION to hold the current DPDK version number.
> Have meson use this file for it's project version, and have make use
> it for reporting out "showversion" and "showversionum".
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Luca Boccassi <bluca at debian.org>
[...]
> --- /dev/null
> +++ b/DPDK_VERSION

Why not VERSION ?

[...]
> --- a/mk/rte.sdkconfig.mk
> +++ b/mk/rte.sdkconfig.mk
>  showversion:
> -	@set -- \
> -		$$(sed -rne 's,^#define RTE_VER_[A-Z_]*[[:space:]]+([0-9]+).*,\1,p' \
> -			-e 's,^#define RTE_VER_SUFFIX[[:space:]]+"(.*)",\1,p' \
> -			$(RTE_SRCDIR)/lib/librte_eal/common/include/rte_version.h) ;\
> -		printf '%d.%02d.%d' "$$1" "$$2" "$$3"; \
> -		if [ -z "$$5" ]; then echo; \
> -		else printf '%s' "$$4"; \
> -			if [ $$5 -lt 16 ] ; then echo $$5; \
> -			else echo $$(($$5 - 16)); fi; \
> -		fi
> +	@cat $(RTE_SRCDIR)/DPDK_VERSION

I'm a bit sad about removing this complex command ;)