[dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names

[Bruce Richardson]

On Wed, Mar 13, 2019 at 03:14:27PM +0000, Ferruh Yigit wrote:
> On 3/13/2019 2:43 PM, Bruce Richardson wrote:
> > On Wed, Mar 13, 2019 at 02:21:31PM +0000, Ferruh Yigit wrote:
> >> On 3/13/2019 1:59 PM, Thomas Monjalon wrote:
> >>> 13/03/2019 14:41, Ferruh Yigit:
> >>>> On 3/12/2019 10:13 PM, Thomas Monjalon wrote:
> >>>>>> Bruce Richardson (6):
> >>>>>>   eal/bsdapp: rename to freebsd
> >>>>>>   eal/linuxapp: rename to linux
> >>>>>>   build/linux: rename macro from LINUXAPP to LINUX
> >>>>>>   build/freebsd: rename macro from BSDPAPP to FREEBSD
> >>>>>>   build/meson: change linuxapp to linux in meson cross files
> >>>>>>   build: allow linux and freebsd in build configs
> >>>>>
> >>>>> Applied, thanks
> >>>>
> >>>> This has potential to break some automation/scripts since changes the names of
> >>>> the config files:
> >>>> 'make T=x86_64-native-linuxapp-gcc config' becomes
> >>>> 'make T=x86_64-native-linux-gcc config' etc...
> >>>>
> >>>> I suggest highlighting this change in release notes!
> >>>
> >>> No, the old names should still work.
> >>> Otherwise, it would be an API breakage, which is very bad!
> >>>
> >>
> >> Ah, right config is working, how I hit this is:
> >>
> >> $ make T=x86_64-native-linuxapp-gcc cscope
> >> Invalid config: x86_64-native-linuxapp-gcc
> >>
> >> 'cscope' (and friends) also should be covered ...
> > 
> > Strange, because the new configs are just symlinks to the old. I'll need to
> > investigate how cscope and friends use the config.
> 
> Are we allowed to use symlinks J Will they play nice on windows?

They'll work well enough. Plus it's only for the old build system, so will
go away in the future.