[dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

[Zhao1, Wei]

Acked-by: Wei Zhao <wei.zhao1 at intel.com>


> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Harton
> Sent: Saturday, March 16, 2019 12:09 AM
> To: dev at dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Ananyev, Konstantin
> <konstantin.ananyev at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>;
> David Harton <dharton at cisco.com>
> Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf
> 
> ixgbevf vlan strip and extend capabilities were removed when migrating to
> the bit flags implementation.
> 
> Restoring the capbility to enable the vlan strip offload at configuration time.
> 
> Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> Signed-off-by: David Harton <dharton at cisco.com>
> ---
> 
>  v4: fixed commit headline/log
>  v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
>  v2: removed unused function ixgbe_is_vf()
> 
>  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e92a70fb3..e71d3c188 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> *dev)
>  		   DEV_RX_OFFLOAD_TCP_CKSUM   |
>  		   DEV_RX_OFFLOAD_KEEP_CRC    |
>  		   DEV_RX_OFFLOAD_JUMBO_FRAME |
> +		   DEV_RX_OFFLOAD_VLAN_FILTER |
>  		   DEV_RX_OFFLOAD_SCATTER;
> 
>  	if (hw->mac.type == ixgbe_mac_82598EB)
>  		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
> 
>  	if (ixgbe_is_vf(dev) == 0)
> -		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
> -			     DEV_RX_OFFLOAD_VLAN_EXTEND);
> +		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
> 
>  	/*
>  	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-
> IOV
> --
> 2.19.1