[dpdk-dev] [PATCH] app/testpmd: fix stdout flush absence after printing stats
Iremonger, Bernard
bernard.iremonger at intel.com
Wed Mar 20 14:21:07 CET 2019
Hi Andrew,
> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko at solarflare.com]
> Sent: Monday, March 18, 2019 11:36 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing
> <jingjing.wu at intel.com>; Iremonger, Bernard
> <bernard.iremonger at intel.com>
> Cc: dev at dpdk.org; Igor Romanov <igor.romanov at oktetlabs.ru>;
> stable at dpdk.org
> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>
> From: Igor Romanov <igor.romanov at oktetlabs.ru>
>
> User can specify stats period(n). The statistics should be available to user
> every n second. But the print_stats() function does not force stdout to be
> flushed, so for instance, a user reading testpmd's stdout through pipe will
> not be able to read it untill the stdout buffer is filled.
>
> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
> Cc: stable at dpdk.org
>
> Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>
> ---
> app/test-pmd/testpmd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> d9d0c16d4..216be47f9 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3046,6 +3046,8 @@ print_stats(void)
> printf("\nPort statistics
> ====================================");
> for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
> nic_stats_display(fwd_ports_ids[i]);
> +
> + fflush(stdout);
> }
>
> static void
> --
> 2.17.1
There is a checkpatch warning on the commit messge.
WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com
More information about the dev
mailing list