[dpdk-dev] [PATCH v3] cryptodev: make xform key pointer constant

Kusztal, ArkadiuszX arkadiuszx.kusztal at intel.com
Wed Mar 20 18:28:29 CET 2019



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Wednesday, March 20, 2019 2:32 PM
> To: dev at dpdk.org
> Cc: akhil.goyal at nxp.com; Zhang, Roy Fan <roy.fan.zhang at intel.com>; Trahe,
> Fiona <fiona.trahe at intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal at intel.com>
> Subject: [PATCH v3] cryptodev: make xform key pointer constant
> 
> This patch changes the key pointer data types in cipher, auth, and aead
> xforms from "uint8_t *" to "const uint8_t *" for a more intuitive and safe
> sessionn creation.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang at intel.com>
> ---
> v3:
> - rebased on top of latest dpdk-next-crypto
> 
> v2:
> - fixed a missed memory free for ixgbe ipsec
>  drivers/common/cpt/cpt_ucode.h                  | 14 ++---
>  drivers/crypto/aesni_gcm/aesni_gcm_pmd.c        |  2 +-
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c      |  2 +-
>  drivers/crypto/openssl/rte_openssl_pmd.c        |  8 +--
>  drivers/crypto/qat/qat_sym_session.c            |  8 +--
>  drivers/crypto/qat/qat_sym_session.h            |  4 +-
>  drivers/crypto/snow3g/rte_snow3g_pmd.c          | 23 ++++++--
>  drivers/crypto/snow3g/rte_snow3g_pmd_private.h  |  1 +
>  drivers/crypto/virtio/virtio_cryptodev.c        | 30 +++++++---
>  drivers/crypto/virtio/virtio_cryptodev.h        |  2 +
>  drivers/net/ixgbe/ixgbe_ipsec.c                 | 35 +++++++++---
>  drivers/net/ixgbe/ixgbe_ipsec.h                 |  3 +-
>  drivers/net/softnic/rte_eth_softnic_cli.c       | 74 ++++++++++++-------------
>  drivers/net/softnic/rte_eth_softnic_internals.h |  4 ++
>  examples/ip_pipeline/cli.c                      | 74 ++++++++++++-------------
>  examples/ip_pipeline/cryptodev.c                |  2 -
>  examples/ip_pipeline/pipeline.h                 |  6 ++
>  examples/l2fwd-crypto/main.c                    | 40 +++++--------


Acked-by: Arek Kusztal <arkadiuszx.kusztal at intel.com>


More information about the dev mailing list