[dpdk-dev] [RFC] net/virtio: remove prefix from virtqueue struct fields

Jens Freimann jfreimann at redhat.com
Thu Mar 21 15:02:44 CET 2019


On Thu, Mar 21, 2019 at 02:45:20PM +0100, Maxime Coquelin wrote:
>Most of 'virtqueue' struct fields are prefixed with 'vq_'.
>This redundant, this patch removes them all.
>
>Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>---
>Hi,
>
>Following our discussions on removing the 'vq_' prefix, I did
>the patch to see how it would look like.
>
>It looks like it does not prevent any lines to be split but one.
>But the code is more readable IMHO.
>
>I send this as RFC to get your feedback.

Yes, I think it's more readable.  One thing I had not thought about is
that it makes it harder to find meaningful results from git blame
output. Can we live with that?

regards,
Jens 


More information about the dev mailing list