[dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure
Maxime Coquelin
maxime.coquelin at redhat.com
Thu Mar 21 15:18:31 CET 2019
On 3/20/19 6:50 PM, Stephen Hemminger wrote:
> On Wed, 20 Mar 2019 12:40:26 +0800
> Tiwei Bie <tiwei.bie at intel.com> wrote:
>
>>> I agree the vq_ prefix is not needed and I think the code is more
>>> readable in general seeing the packed/split name when using the struct.
>>>
>>> Please also consider that cosmetic changes in multiple places likely
>>> mean backports will not apply cleanly to the stable branches anymore, so
>>> it does have a cost.
>>
>> Yeah, agree.
>
>
> prefixing structure elements is an old school BSD thing back from when
> compilers were not smart about namespaces for identifiers.
Ha, good to know! I wasn't aware of that.
>
> Agree that it is no longer needed.
>
More information about the dev
mailing list