[dpdk-dev] [PATCH v4 1/3] rwlock: reimplement with atomic builtins
Ananyev, Konstantin
konstantin.ananyev at intel.com
Thu Mar 21 19:43:21 CET 2019
> -----Original Message-----
> From: Joyce Kong [mailto:joyce.kong at arm.com]
> Sent: Wednesday, March 20, 2019 6:25 AM
> To: dev at dpdk.org
> Cc: nd at arm.com; jerinj at marvell.com; Ananyev, Konstantin <konstantin.ananyev at intel.com>; chaozhu at linux.vnet.ibm.com; Richardson,
> Bruce <bruce.richardson at intel.com>; thomas at monjalon.net; hemant.agrawal at nxp.com; honnappa.nagarahalli at arm.com;
> gavin.hu at arm.com
> Subject: [PATCH v4 1/3] rwlock: reimplement with atomic builtins
>
> The __sync builtin based implementation generates full memory
> barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins
> to generate one way barriers.
>
> Here is the assembly code of __sync_compare_and_swap builtin.
> __sync_bool_compare_and_swap(dst, exp, src);
> 0x000000000090f1b0 <+16>: e0 07 40 f9 ldr x0, [sp, #8]
> 0x000000000090f1b4 <+20>: e1 0f 40 79 ldrh w1, [sp, #6]
> 0x000000000090f1b8 <+24>: e2 0b 40 79 ldrh w2, [sp, #4]
> 0x000000000090f1bc <+28>: 21 3c 00 12 and w1, w1, #0xffff
> 0x000000000090f1c0 <+32>: 03 7c 5f 48 ldxrh w3, [x0]
> 0x000000000090f1c4 <+36>: 7f 00 01 6b cmp w3, w1
> 0x000000000090f1c8 <+40>: 61 00 00 54 b.ne 0x90f1d4
> <rte_atomic16_cmpset+52> // b.any
> 0x000000000090f1cc <+44>: 02 fc 04 48 stlxrh w4, w2, [x0]
> 0x000000000090f1d0 <+48>: 84 ff ff 35 cbnz w4, 0x90f1c0
> <rte_atomic16_cmpset+32>
> 0x000000000090f1d4 <+52>: bf 3b 03 d5 dmb ish
> 0x000000000090f1d8 <+56>: e0 17 9f 1a cset w0, eq // eq = none
>
> Signed-off-by: Gavin Hu <gavin.hu at arm.com>
> Signed-off-by: Joyce Kong <joyce.kong at arm.com>
> Tested-by: Joyce Kong <joyce.kong at arm.com>
> Acked-by: Jerin Jacob <jerinj at marvell.com>
> ---
> lib/librte_eal/common/include/generic/rte_rwlock.h | 29 +++++++++++-----------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/generic/rte_rwlock.h b/lib/librte_eal/common/include/generic/rte_rwlock.h
> index b05d85a..de94ca9 100644
> --- a/lib/librte_eal/common/include/generic/rte_rwlock.h
> +++ b/lib/librte_eal/common/include/generic/rte_rwlock.h
> @@ -64,14 +64,14 @@ rte_rwlock_read_lock(rte_rwlock_t *rwl)
> int success = 0;
>
> while (success == 0) {
> - x = rwl->cnt;
> + x = __atomic_load_n(&rwl->cnt, __ATOMIC_RELAXED);
> /* write lock is held */
> if (x < 0) {
> rte_pause();
> continue;
> }
> - success = rte_atomic32_cmpset((volatile uint32_t *)&rwl->cnt,
> - (uint32_t)x, (uint32_t)(x + 1));
> + success = __atomic_compare_exchange_n(&rwl->cnt, &x, x+1, 1,
As a nit, here and in trylock: 'x+1' spaces missing, needs to be 'x + 1'.
Apart from that:
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
More information about the dev
mailing list