[dpdk-dev] [PATCH v3 1/5] net/af_xdp: introduce AF XDP PMD driver

Ye Xiaolong xiaolong.ye at intel.com
Fri Mar 22 02:55:10 CET 2019


On 03/21, Stephen Hemminger wrote:
>On Thu, 21 Mar 2019 17:18:41 +0800
>Xiaolong Ye <xiaolong.ye at intel.com> wrote:
>
>> +	if (strnlen(value, IFNAMSIZ) > IFNAMSIZ - 1) {
>> +		RTE_LOG(ERR, AF_XDP, "Invalid name %s, should be less than "
>> +			"%u bytes.\n", value, IFNAMSIZ)
>
>Please don't break error message strings across multiple source lines.
>It makes it harder to use tools like grep to find errors in source.

Good point, will keep this in mind.

Thanks,
Xiaolong


More information about the dev mailing list