[dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support
Varghese, Vipin
vipin.varghese at intel.com
Thu May 2 10:04:02 CEST 2019
Hi Suanming,
snipped
>
> /* true if x is a power of 2 */
> #define POWEROF2(x) ((((x)-1) & (x)) == 0) @@ -413,6 +416,18 @@ struct
Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
> parse_val { }
>
> static void
> +monitor_primary(void *arg __rte_unused) {
> + if (quit_signal)
> + return;
> +
> + if (rte_eal_primary_proc_alive(NULL))
> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,
> NULL);
> + else
> + quit_signal = 1;
> +}
This is suggestion, why not omit else part with
`
if (rte_eal_primary_proc_alive(NULL)) {
rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary,NULL);
return;
}
`
Snipped
As suggested in v4 can you update the `pdump.rst` on the new behaviour?
Thanks
Vipin Varghese
More information about the dev
mailing list