[dpdk-dev] [PATCH v6] app/pdump: add pudmp exits with primary support

Varghese, Vipin vipin.varghese at intel.com
Thu May 2 11:22:55 CEST 2019

HI Suanming,

> >>   /* true if x is a power of 2 */
> >>   #define POWEROF2(x) ((((x)-1) & (x)) == 0) @@ -413,6 +416,18 @@
> >> struct
> > Can we use ` RTE_IS_POWER_OF_2(n) ' instead of ` POWEROF2`?
> I'm sorry, but that line is not add by this patch this time.
> Maybe another commit is more suitable to fix the previous code.

> >
> > As suggested in v4 can you update the `pdump.rst` on the new behaviour?
> As noted in the cover letter in v5. The `exit with primary` configuration should be
> made as default or not is still not confirmed from the maintainer.
> Since `exit with primary` is now removed in the patch and made as default per
> Anatoly's suggestion and not get more information from the maintainer, the
> update of the doc is also got hung up.

I am not clear with this, if there is change in behaviour of the application it has to be documented.

Vipin Varghese

More information about the dev mailing list