[dpdk-dev] [PATCH v7] app/pdump: add pudmp exits with primary support
mousuanming
mousuanming at huawei.com
Thu May 2 14:35:32 CEST 2019
Ah, yes!
I'm so sorry that I have left the company today. It's not able to update the patch now.
I think it will be done tomorrow.
Thanks again for your suggestions enriched that simple patch.
(May the reply on mobile phone won't break any mail formats)
--------------------------------------------------
Mou Suanming
Email: mousuanming at huawei.com<mailto:mousuanming at huawei.com>
发件人:Burakov, Anatoly <anatoly.burakov at intel.com>
收件人:mousuanming <mousuanming at huawei.com>;dev at dpdk.org <dev at dpdk.org>
抄 送:vipin.varghese at intel.com <vipin.varghese at intel.com>
时间:2019-05-02 19:31:51
主 题:Re: [PATCH v7] app/pdump: add pudmp exits with primary support
On 02-May-19 1:35 PM, Suanming.Mou wrote:
> When primary app exits, the residual running pdump will stop the
> primary app to restart. Add pdump exits with primary support.
>
> Signed-off-by: Suanming.Mou <mousuanming at huawei.com>
> ---
<...>
> + if (rte_eal_primary_proc_alive(NULL)) {
> + rte_eal_alarm_set(MONITOR_INTERVAL, monitor_primary, NULL);
> + return;
> + }
> +
> + printf("Exiting dump while primary is not alive...\n");
May i suggest rewording:
Primary process is no longer active, exiting
I think the above would be clearer.
Otherwise,
Reviewed-by: Anatoly Burakov <anatoly.burakov at intel.com>
> + quit_signal = 1;
> +}
> +
> +static void
> print_pdump_stats(void)
> {
<snip>
> + disable_primary_monitor();
> cleanup_pdump_resources();
> /* dump debug stats */
> print_pdump_stats();
> diff --git a/doc/guides/tools/pdump.rst b/doc/guides/tools/pdump.rst
> index 53cd2b4..62b4a5e 100644
> --- a/doc/guides/tools/pdump.rst
> +++ b/doc/guides/tools/pdump.rst
> @@ -26,6 +26,8 @@ a DPDK secondary process and is capable of enabling packet capture on dpdk ports
> Once the libpcap development files are installed, the libpcap based PMD
> can be enabled by setting CONFIG_RTE_LIBRTE_PMD_PCAP=y and recompiling the DPDK.
>
> + * The ``dpdk-pdump`` tool runs as a DPDK secondary process. It exits when
> + the primary application exits.
>
> Running the Application
> -----------------------
>
Worth adding this to release notes as well?
--
Thanks,
Anatoly
More information about the dev
mailing list