[dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions

Yongseok Koh yskoh at mellanox.com
Thu May 2 20:13:14 CEST 2019


> On May 2, 2019, at 8:01 AM, Dekel Peled <dekelp at mellanox.com> wrote:
> 
> Functions implemented but never called:
> mlx5_rxq_ibv_releasable()
> mlx5_rxq_cleanup()
> mlx5_txq_ibv_releasable()
> 
> Function declared but not implemented:
> rxq_alloc_mprq_buf()
> 
> This patch removes these functions from code and header file.
> 
> Signed-off-by: Dekel Peled <dekelp at mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh at mellanox.com>


> drivers/net/mlx5/mlx5_rxq.c  | 31 -------------------------------
> drivers/net/mlx5/mlx5_rxtx.h |  4 ----
> drivers/net/mlx5/mlx5_txq.c  | 13 -------------
> 3 files changed, 48 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index 54438a4..db8c340 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -368,24 +368,6 @@
> }
> 
> /**
> - * Clean up a RX queue.
> - *
> - * Destroy objects, free allocated memory and reset the structure for reuse.
> - *
> - * @param rxq_ctrl
> - *   Pointer to RX queue structure.
> - */
> -void
> -mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl)
> -{
> -	DRV_LOG(DEBUG, "port %u cleaning up Rx queue %u",
> -		PORT_ID(rxq_ctrl->priv), rxq_ctrl->rxq.idx);
> -	if (rxq_ctrl->ibv)
> -		mlx5_rxq_ibv_release(rxq_ctrl->ibv);
> -	memset(rxq_ctrl, 0, sizeof(*rxq_ctrl));
> -}
> -
> -/**
>  * Returns the per-queue supported offloads.
>  *
>  * @param dev
> @@ -1131,19 +1113,6 @@ struct mlx5_rxq_ibv *
> }
> 
> /**
> - * Return true if a single reference exists on the object.
> - *
> - * @param rxq_ibv
> - *   Verbs Rx queue object.
> - */
> -int
> -mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv)
> -{
> -	assert(rxq_ibv);
> -	return (rte_atomic32_read(&rxq_ibv->refcnt) == 1);
> -}
> -
> -/**
>  * Callback function to initialize mbufs for Multi-Packet RQ.
>  */
> static inline void
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index 0d88375..1732e32 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -251,7 +251,6 @@ struct mlx5_txq_ctrl {
> int mlx5_mprq_enabled(struct rte_eth_dev *dev);
> int mlx5_mprq_free_mp(struct rte_eth_dev *dev);
> int mlx5_mprq_alloc_mp(struct rte_eth_dev *dev);
> -void mlx5_rxq_cleanup(struct mlx5_rxq_ctrl *rxq_ctrl);
> int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> 			unsigned int socket, const struct rte_eth_rxconf *conf,
> 			struct rte_mempool *mp);
> @@ -263,7 +262,6 @@ int mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_rxq_ibv_release(struct mlx5_rxq_ibv *rxq_ibv);
> -int mlx5_rxq_ibv_releasable(struct mlx5_rxq_ibv *rxq_ibv);
> struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev);
> void mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev);
> int mlx5_rxq_ibv_verify(struct rte_eth_dev *dev);
> @@ -276,7 +274,6 @@ struct mlx5_rxq_ctrl *mlx5_rxq_new(struct rte_eth_dev *dev, uint16_t idx,
> int mlx5_rxq_releasable(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_rxq_verify(struct rte_eth_dev *dev);
> int rxq_alloc_elts(struct mlx5_rxq_ctrl *rxq_ctrl);
> -int rxq_alloc_mprq_buf(struct mlx5_rxq_ctrl *rxq_ctrl);
> struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_new(struct rte_eth_dev *dev,
> 						  const uint16_t *queues,
> 						  uint32_t queues_n);
> @@ -314,7 +311,6 @@ int mlx5_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
> struct mlx5_txq_ibv *mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t idx);
> struct mlx5_txq_ibv *mlx5_txq_ibv_get(struct rte_eth_dev *dev, uint16_t idx);
> int mlx5_txq_ibv_release(struct mlx5_txq_ibv *txq_ibv);
> -int mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv);
> int mlx5_txq_ibv_verify(struct rte_eth_dev *dev);
> struct mlx5_txq_ctrl *mlx5_txq_new(struct rte_eth_dev *dev, uint16_t idx,
> 				   uint16_t desc, unsigned int socket,
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index 0b6c247..2cdb1d3 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -668,19 +668,6 @@ struct mlx5_txq_ibv *
> }
> 
> /**
> - * Return true if a single reference exists on the object.
> - *
> - * @param txq_ibv
> - *   Verbs Tx queue object.
> - */
> -int
> -mlx5_txq_ibv_releasable(struct mlx5_txq_ibv *txq_ibv)
> -{
> -	assert(txq_ibv);
> -	return (rte_atomic32_read(&txq_ibv->refcnt) == 1);
> -}
> -
> -/**
>  * Verify the Verbs Tx queue list is empty
>  *
>  * @param dev
> -- 
> 1.8.3.1
> 



More information about the dev mailing list