[dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension
Jerin Jacob Kollanukkaran
jerinj at marvell.com
Tue May 7 09:59:14 CEST 2019
> -----Original Message-----
> From: Yongseok Koh <yskoh at mellanox.com>
> Sent: Tuesday, May 7, 2019 3:17 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; Thomas Monjalon
> <thomas at monjalon.net>; dev at dpdk.org; bruce.richardson at intel.com;
> Pavan Nikhilesh Bhagavatula <pbhagavatula at marvell.com>; Shahaf Shuler
> <shahafs at mellanox.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu at arm.com>; stable at dpdk.org; Luca Boccassi
> <bluca at debian.org>; nd <nd at arm.com>
> Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 crypto
> > On May 3, 2019, at 10:50 AM, Yongseok Koh <yskoh at mellanox.com>
> >> I think this change might have an impact on the existing users. Does
> >> this change need to be documented somewhere (at least in the release
> > Practically, there would be no impact. Even if user's app makes use of
> > crypto instructions, the build config of the app should have the flag.
> On IRC, I could see you concerned about the case where user app derives
> build flags from DPDK like apps under the examples directory. Yes, that's a
> valid concern.
Is there any DPDK example application would depend on the armv8 crypto flags? IMO, None of
the applications are directly using armv8 crypto instruction. Even such as comes for any external DPDK
app which is not in dpdk.org tree then it can be added in APP makefile.
IMO, app writes should be aware of the need for using +crypto if he/she using the crypto instruction.
> Thomas/Jerin, where could be the best spot to document it? Just release
> I think release note would be fine.
More information about the dev