[dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>
> Sent: Tuesday, May 7, 2019 4:34 PM
> To: Jerin Jacob Kollanukkaran <jerinj at marvell.com>; yskoh at mellanox.com
> Cc: thomas at monjalon.net; dev at dpdk.org; bruce.richardson at intel.com; Pavan
> Nikhilesh Bhagavatula <pbhagavatula at marvell.com>; Shahaf Shuler
> <shahafs at mellanox.com>; Gavin Hu (Arm Technology China)
> <Gavin.Hu at arm.com>; stable at dpdk.org; Luca Boccassi <bluca at debian.org>;
> nd <nd at arm.com>; nd <nd at arm.com>
> Subject: [EXT] RE: [dpdk-stable] [PATCH v2] build: disable armv8 crypto
> extension
> 
> > > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8
> > > crypto extension
> > >
> > > > On May 3, 2019, at 10:50 AM, Yongseok Koh <yskoh at mellanox.com>
> > > wrote:
> > > >
> > > >> I think this change might have an impact on the existing users.
> > > >> Does this change need to be documented somewhere (at least in the
> > > >> release
> > > notes)?
> > > >
> > > > Practically, there would be no impact. Even if user's app makes
> > > > use of crypto instructions, the build config of the app should have the flag.
> > >
> > > On IRC, I could see you concerned about the case where user app
> > > derives build flags from DPDK like apps under the examples directory.
> > > Yes, that's a valid concern.
> >
> > Is there any DPDK example application would depend on the armv8 crypto
> > flags? IMO, None of the applications are directly using armv8 crypto
> It is not about DPDK's example application. We have control over that.
> 
> > instruction. Even such as comes for any external DPDK app which is not
> > in dpdk.org tree then it can be added in APP makefile.
> > IMO, app writes should be aware of the need for using +crypto if
> > he/she using the crypto instruction.
> Agree. But, it might be that the app writer might have depended on the +crypto
> coming from DPDK build system, in which case, she/he needs to know the
> change through release notes?
> 
> I do not think it needs to be documented anywhere else.

Agree and no harm in updating the release notes.

> 
> >
> > >
> > > Thomas/Jerin, where could be the best spot to document it? Just
> > > release note?
> > > I think release note would be fine.
> >