[dpdk-dev] [PATCH] net/sfc: fix MTU change to check Rx scatter consistency

Kevin Traynor ktraynor at redhat.com
Wed May 8 18:06:42 CEST 2019


On 23/04/2019 09:14, Andrew Rybchenko wrote:
> From: Igor Romanov <igor.romanov at oktetlabs.ru>
> 
> Rx queue setup function checks configured MTU to make sure that
> no oversized packets can be received. But a following call to
> set MTU function might make this check irrelevant.
> 
> Add a function to check MTU size against Rx buffer size and
> additional Rx queue info, including Rx scatter offload.
> 
> Fixes: e961cf425e02 ("net/sfc: support MTU change")
> Cc: stable at dpdk.org
> 

Hi again - this one is causing a build failure on 18.11 branch. Please
send a backport or let me know if it's not required.

  CC sfc_ethdev.o
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c: In
function ‘sfc_check_scatter_on_all_rx_queues’:
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: implicit declaration of function ‘sfc_sa2shared’; did you mean
‘sfc_stats_get’? [-Werror=implicit-function-declaration]
  struct sfc_adapter_shared * const sas = sfc_sa2shared(sa);
                                          ^~~~~~~~~~~~~
                                          sfc_stats_get
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: nested extern declaration of ‘sfc_sa2shared’ [-Werror=nested-externs]
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:865:42:
error: initialization of ‘struct sfc_adapter_shared * const’ from ‘int’
makes pointer from integer without a cast [-Werror=int-conversion]
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:871:21:
error: dereferencing pointer to incomplete type ‘struct sfc_adapter_shared’
  for (i = 0; i < sas->rxq_count; i++) {
                     ^~
/home/ktraynor/code/lts/dpdk-stable/drivers/net/sfc/sfc_ethdev.c:878:38:
error: ‘struct sfc_adapter’ has no member named ‘rxq_ctrl’; did you mean
‘rxq_max’?
   if (!sfc_rx_check_scatter(pdu, sa->rxq_ctrl[i].buf_size,
                                      ^~~~~~~~
                                      rxq_max


> Signed-off-by: Igor Romanov <igor.romanov at oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com>



More information about the dev mailing list