[dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP

Thomas Monjalon thomas at monjalon.net
Thu May 9 16:27:58 CEST 2019

09/05/2019 13:23, Ayuj Verma:
> Currently some tests return TEST_SKIPPED/-1 when tests or params
> are not supported for particular PMD because of which tests adds to
> FAILED test counter in place of Skipped/Unsupported counter.

It looks to be a bug that TEST_SKIPPED is not caught to increment
"skipped" counter. Please fix it.

> Since unsupported test is not a failure case,
> replace return value TEST_SKIPPED/-1 with -ENOTSUP

I would say the right reason is that the test is not supported by the HW.

> - Return -ENOTSUP for unsupported tests
> - add NULL check for rte_cryptodev_asym_capability_get()
> - Typo correction
> Signed-off-by: Ayuj Verma <ayverma at marvell.com>
> Signed-off-by: Shally Verma <shallyv at marvell.com>

I am not sure what the "skipped" counter is supposed to represent
if it's not for the unsupported cases.
There is a gap to check and document here.

Applied, as it sounds right to return ENOTSUP in those cases.

More information about the dev mailing list