[dpdk-dev] [PATCH] devtools: select patches to check with git range

Thomas Monjalon thomas at monjalon.net
Thu May 9 23:54:00 CEST 2019


22/03/2019 14:16, David Marchand:
> --- a/devtools/checkpatches.sh
> +++ b/devtools/checkpatches.sh
> -	usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]]
> +	usage: $(basename $0) [-q] [-v] [-nX|patch1 [patch2] ...]] [-r range]

The option -r should be before the filename arguments,
and inside the same brackets as -n as they are exclusive.
(je clair ne pas ;)

>  	The patches to check can be from stdin, files specified on the command line,
> -	or latest git commits limited with -n option (default limit: origin/master).
> +	or latest git commits limited with -n option or commits in the range
> +	specified with -r option (default: origin/master..).

I suggest this reword:

  	The patches to check can be from stdin, files specified on the command line,
	latest git commits limited with -n option, or commits in the git range
	specified with -r option (default: "origin/master..").

[...]
>  	if [ $number -eq 0 ] ; then
> -		commits=$(git rev-list --reverse origin/master..)
> +		commits=$(git rev-list --reverse $range)
>  	else
>  		commits=$(git rev-list --reverse --max-count=$number HEAD)
>  	fi

Looks good and very useful, thanks :)






More information about the dev mailing list