[dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD

[Smoczynski, MarcinX]

10/05/2019 20:17, Thomas Monjalon:
> 10/05/2019 19:14, Smoczynski, MarcinX:
> > To summarize we have different visibility sets for Linux and BSD 
> > when using XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome 
> > this situation we can either remove problematic XOPEN macros from 
> > mk/meson rules (drivers/net/failsafe, drivers/net/mlx4, 
> > drivers/net/mlx5)
> 
> What is the consequence of removing these macros in mlx and failsafe PMDs?

The purpose of these *_SOURCE constants is to enable particular feature sets
visibility. As long as we have GNU_SOURCE on Linux removing it won't have any
consequences. On BSD it will unify feature sets visibility with the rest of
sources. Can't think of any downsides here.

I believe XOPEN_SOURCE was introduced to extend features not to restrict them.

MS