[dpdk-dev] [PATCH v2] net/i40e: Eliminate weak symbols in i40e_rxtx.c

Bruce Richardson bruce.richardson at intel.com
Thu May 16 16:08:49 CEST 2019


On Wed, May 15, 2019 at 12:13:46PM -0400, David Harton wrote:
> Use of weak symbols can hide makefile errors especially when
> custom makefiles are used.  Removing the use of weak symbols
> to avoid a stub function being linked in production code.
> 
> Signed-off-by: David Harton <dharton at cisco.com>
> ---
> 
> v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors
> 
Testing a few compiles here, this breaks when vector mode is disabled,
because it's possible that CC_AVX2_SUPPORT=1 when VECTOR=n. I'd suggest
adding "ifeq ($(CONFIG_RTE_LIBRTE_I40E_INC_VECTOR),y) ... endif" around the
block in the makefile checking for AVX2 support, so that we never set AVX2
unless we have vector support.

With this change, you can include my ack in v3.

/Bruce 

Acked-by: Bruce Richardson <bruce.richardson at intel.com>


More information about the dev mailing list