[dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance

Ergin, Mesut A mesut.a.ergin at intel.com
Thu May 16 22:57:09 CEST 2019



> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Thursday, May 16, 2019 1:18 AM
> To: Ergin, Mesut A <mesut.a.ergin at intel.com>; Xing, Beilei
> <beilei.xing at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector
> RX allowance
> 
> 
> 
> On 5/16/19 6:28 AM, Mesut Ali Ergin wrote:
> > When i40e_rx_vec_dev_conf_condition_check_default() determines whether
> > vector receive functions would be allowed during initialization phase,
> > it should honor previously recorded disallowance during configuration
> > phase, and not override simply because it is for the first queue.
> >
> > Signed-off-by: Mesut Ali Ergin <mesut.a.ergin at intel.com>
> > ---
> >   drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > index 0e6ffa0..f30cab4 100644
> > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> > @@ -212,6 +212,10 @@
> i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
> >   	if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)
> >   		return -1;
> >
> > +	/* Should not override if vector was already disallowed */
> > +	if (!ad->rx_vec_allowed)
> > +	return -1;
> 
> nit: wrong indentation.

Thanks. Fixed, and queued for v2 -- my checkpatch misses this for some reason.
> 
> > +
> >   	/**
> >   	 * Vector mode is allowed only when number of Rx queue
> >   	 * descriptor is power of 2.
> >


More information about the dev mailing list