[dpdk-dev] [PATCH] net/virtio: remove useless check on mempool

David Marchand david.marchand at redhat.com
Fri May 17 10:16:27 CEST 2019

On Thu, May 9, 2019 at 3:29 PM Jens Freimann <jfreimann at redhat.com> wrote:

> On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote:
> >This .rx_queue_setup devop is called after ethdev already dereferenced
> >the mempool pointer.
> >No need to check and we can remove this rte_exit.
> >
> >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper
> place")
> >Cc: stable at dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand at redhat.com>
> Agree, the pointer is accessed before in the caller. That said, afaics the
> pointer is never checked in rte_eth_rx_queue_setup() before it's
> dereferenced...

Yep, sent a patch.

Thanks for the review Jens.

David Marchand

More information about the dev mailing list