[dpdk-dev] [PATCH] compress/isal: fix use after free
Stephen Hemminger
stephen at networkplumber.org
Tue May 21 16:47:13 CEST 2019
The release function was using qp->stream after already
releasing it and the null pointer checking was missing.
Also since rte_free(NULL) is a no-op, remove unnecessary
checks for NULL.
Coverity issure: 340860
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/compress/isal/isal_compress_pmd_ops.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index fe9995992304..77ac6fcf21fc 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -171,18 +171,12 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
if (qp == NULL)
return -EINVAL;
- if (qp->stream != NULL)
- rte_free(qp->stream);
-
- if (qp->stream->level_buf != NULL)
+ if (qp->stream)
rte_free(qp->stream->level_buf);
- if (qp->state != NULL)
- rte_free(qp->state);
-
- if (qp->processed_pkts != NULL)
- rte_ring_free(qp->processed_pkts);
-
+ rte_free(qp->state);
+ rte_ring_free(qp->processed_pkts);
+ rte_free(qp->stream);
rte_free(qp);
dev->data->queue_pairs[qp_id] = NULL;
--
2.20.1
More information about the dev
mailing list