[dpdk-dev] [PATCH v1] hash: simplify signature compare neon process
yipeng1.wang at intel.com
Wed May 22 02:28:17 CEST 2019
>From: Ruifeng Wang [mailto:ruifeng.wang at arm.com]
>Sent: Monday, April 29, 2019 3:02 AM
>To: Wang, Yipeng1 <yipeng1.wang at intel.com>; Gobriel, Sameh <sameh.gobriel at intel.com>; Richardson, Bruce
><bruce.richardson at intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>Cc: dev at dpdk.org; jerinj at marvell.com; Honnappa.Nagarahalli at arm.com; nd at arm.com; Ruifeng Wang <ruifeng.wang at arm.com>
>Subject: [PATCH v1] hash: simplify signature compare neon process
>Replaced multiple neon instructions with single equivalent instruction.
>This made simpler code and a bit higher performance.
>Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72
>Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
>Reviewed-by: Gavin Hu <gavin.hu at arm.com>
[Wang, Yipeng] Sorry for the late review.
The logic seems fine to me based on my understanding of the instructions.
But I don't have an ARM machine to test. Please make sure
It passes the compilation and unit tests.
Or others (Jerin maybe?) could provide more feedback?
Acked-by: Yipeng Wang <yipeng1.wang at intel.com>
More information about the dev