[dpdk-dev] [PATCH] librte_eal: ease init in a docker container

Burakov, Anatoly anatoly.burakov at intel.com
Thu May 23 10:56:22 CEST 2019


On 22-May-19 4:41 PM, Nicolas Dichtel wrote:
> move_pages() is only used to get the numa node id, but this function
> is not allowed by default in docker (it needs CAP_SYS_NICE and an update of
> the seccomp profile).
> get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in
> the default seccomp profile.
> 
> Note that the returned value of move_pages() was not checked, thus some
> errors could be hidden (if the requested id was 0).
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz at 6wind.com>
> Reviewed-by: Didier Pallard <didier.pallard at 6wind.com>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

Still, should at least specify Cc: stable, if not Fixes tag too (since 
ignoring return value of move_pages() is technically a bug).

-- 
Thanks,
Anatoly


More information about the dev mailing list