[dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx

Ergin, Mesut A mesut.a.ergin at intel.com
Thu May 23 19:54:27 CEST 2019


> > > > > If you plan to use FD mode on your device, why not enable it
> > > > > at setup phase via rte_eth_dev_configure()?
> > > > > Then proper rx function would be selected.
> > > > >
> > > >
> > > > FDIR_MODE was designed to bind late automatically -- it is set when the
> first
> > > > filter rule is parsed, and unset when the last rule is removed.
> > >
> > > Why is that, if you can define it at configuration stage, and RX function
> > > selection is based on it?
> >
> > I don't know why it was designed that way -- maybe maintainers know the
> > historical context.
> 
> What I am trying to say - if particular feature (FD) enablement/disablement
> affects RX/TX function selection, then there should be an ability to
> enable/disable
> that feature at configuration state (dev_config/queue_setup).
> Function to change value of that feature at runtime (after
> dev_start/queue_start)
> should return an error if new value can't be supported with already selected
> RX/TX
> function.
> If that's is not the case, then it sounds like a bug/gap in i40e driver that needs to
> be fixed.

Will send a fix for that shortly.


More information about the dev mailing list