[dpdk-dev] [PATCH] compress/isal: fix use after free

[Trahe, Fiona]

> -----Original Message-----
> From: Daly, Lee
> Sent: Tuesday, May 21, 2019 4:08 PM
> To: Stephen Hemminger <stephen at networkplumber.org>
> Cc: dev at dpdk.org; Trahe, Fiona <fiona.trahe at intel.com>
> Subject: RE: [PATCH] compress/isal: fix use after free
> 
> Hi Stephen,
> Thanks for the patch.
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > Sent: Tuesday, May 21, 2019 3:47 PM
> > To: Daly, Lee <lee.daly at intel.com>
> > Cc: dev at dpdk.org; Stephen Hemminger <stephen at networkplumber.org>
> > Subject: [PATCH] compress/isal: fix use after free
> >
> > The release function was using qp->stream after already releasing it and the
> > null pointer checking was missing.
> >
> > Also since rte_free(NULL) is a no-op, remove unnecessary checks for NULL.
> >
> > Coverity issure: 340860
> > Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
Acked-by: Lee Daly <lee.daly at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>